Re: [gentoo-portage-dev] [PATCH] repoman: Add file encoding sheband for py-2.7 compatibility

[Brian Dolbec]

On Sat, 3 Oct 2015 10:19:41 -0700
Zac Medico <zmedico@g.o> wrote:

> On 10/03/2015 09:08 AM, Brian Dolbec wrote:
> > From 841660a8064012b734b5c62e1c1e3e1132403d5c Mon Sep 17 00:00:00
> > 2001 From: Brian Dolbec <dolsen@g.o>
> > Date: Sat, 3 Oct 2015 08:57:55 -0700
> > Subject: [PATCH] repoman: Add file encoding sheband for py-2.7
> > compatibility (bug 562108)
> >
> > This makes python treat all string declarations as unicode strings.
> > This prevents errors like getting an unicode string via the command
> > line and it being added to an ascii string.
> >
> > X-Gentoo-bug: 562108
> > X-Gentoo-bug-url: https://bugs.gentoo.org/show_bug.cgi?id=562108
> > ---
>
> I don't have anything against adding these unicode shebangs, but they
> won't fix the problem, because they only change the interpreted
> encoding of literals embedded in python files. Under python2, that
> means the literals are still plain bytes, just with a different
> encoding. You have to use 'from __future__ import unicode_literals'
> if you really want string literals to behave as unicode strings.

Yes, all files that used any print() already imported both
print_function and unicode_literals.

-- 
Brian Dolbec <dolsen>