Gentoo Archives: gentoo-portage-dev

From: Zac Medico <zmedico@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH] depgraph: clarify "update has been skipped" message (bug 602854)
Date: Thu, 29 Dec 2016 09:14:58
Message-Id: 42f1cb57-c494-fab9-55fe-bdbf6021891f@gentoo.org
In Reply to: Re: [gentoo-portage-dev] [PATCH] depgraph: clarify "update has been skipped" message (bug 602854) by Brian Dolbec
1 On 12/28/2016 05:25 PM, Brian Dolbec wrote:
2 > On Wed, 28 Dec 2016 16:01:04 -0800
3 > Zac Medico <zmedico@g.o> wrote:
4 >
5 >> When an update has been skipped, clearly display both the selected and
6 >> skipped packages.
7 >>
8 >> X-Gentoo-bug: 602854
9 >> X-Gentoo-bug-url: https://bugs.gentoo.org/602854
10 >> ---
11 >> pym/_emerge/depgraph.py | 9 ++++++++-
12 >> 1 file changed, 8 insertions(+), 1 deletion(-)
13 >>
14 >> diff --git a/pym/_emerge/depgraph.py b/pym/_emerge/depgraph.py
15 >> index cb12b05..e298337 100644
16 >> --- a/pym/_emerge/depgraph.py
17 >> +++ b/pym/_emerge/depgraph.py
18 >> @@ -1044,7 +1044,14 @@ class depgraph(object):
19 >> writemsg(str(pkg.slot_atom), noiselevel=-1)
20 >> if pkg.root_config.settings["ROOT"] != "/":
21 >> writemsg(" for %s" % (pkg.root,),
22 >> noiselevel=-1)
23 >> - writemsg("\n", noiselevel=-1)
24 >> + writemsg("\n\n", noiselevel=-1)
25 >> +
26 >> + selected_pkg =
27 >> next(self._dynamic_config._package_tracker.match(
28 >> + pkg.root, pkg.slot_atom), None)
29 >> +
30 >> + writemsg(" selected: %s\n" %
31 >> (selected_pkg,), noiselevel=-1)
32 >> + writemsg(" skipped: %s (see unsatisfied
33 >> dependency below)\n"
34 >> + % (pkg,), noiselevel=-1)
35 >>
36 >> for parent, root, atom in parent_atoms:
37 >> self._show_unsatisfied_dep(root,
38 >> atom, myparent=parent)
39 >
40 >
41 > looks good :)
42 >
43
44 Thanks, pushed:
45
46 https://gitweb.gentoo.org/proj/portage.git/commit/?id=7dc23bc66b410b5a2f9640dc93ca65f5b2678670
47 --
48 Thanks,
49 Zac