Gentoo Archives: gentoo-portage-dev

From: "Ulrich Müller" <ulm@g.o>
To: gentoo-portage-dev@l.g.o
Subject: [gentoo-portage-dev] [PATCH] dosym: Make implicit basename a fatal error.
Date: Mon, 17 Apr 2017 10:18:33
Message-Id: 22772.38513.229424.784501@a1i15.kph.uni-mainz.de
1 The respective QA warning in the dosym helper is in place since 2011.
2 All known violations in the gentoo repository have been fixed.
3
4 Gentoo-Bug: 379899
5 ---
6 bin/ebuild-helpers/dosym | 7 +++----
7 1 file changed, 3 insertions(+), 4 deletions(-)
8
9 diff --git a/bin/ebuild-helpers/dosym b/bin/ebuild-helpers/dosym
10 index 0bc8cc7be..b9c70ce9c 100755
11 --- a/bin/ebuild-helpers/dosym
12 +++ b/bin/ebuild-helpers/dosym
13 @@ -1,5 +1,5 @@
14 #!/bin/bash
15 -# Copyright 1999-2012 Gentoo Foundation
16 +# Copyright 1999-2017 Gentoo Foundation
17 # Distributed under the terms of the GNU General Public License v2
18
19 source "${PORTAGE_BIN_PATH}"/isolated-functions.sh || exit 1
20 @@ -13,10 +13,9 @@ if ! ___eapi_has_prefix_variables; then
21 ED=${D}
22 fi
23
24 -if [[ ${2} == */ ]] || \
25 - [[ -d ${ED}${2} && ! -L ${ED}${2} ]] ; then
26 +if [[ ${2} == */ ]] || [[ -d ${ED}${2} && ! -L ${ED}${2} ]] ; then
27 # implicit basename not allowed by PMS (bug #379899)
28 - eqawarn "QA Notice: dosym target omits basename: '${2}'"
29 + __helpers_die "${0##*/}: dosym target omits basename: '${2}'"
30 fi
31
32 destdir=${2%/*}
33 --
34 2.12.2