Gentoo Archives: gentoo-portage-dev

From: "Göktürk Yüksek" <gokturk@g.o>
To: gentoo-portage-dev@l.g.o
Subject: [gentoo-portage-dev] [PATCH v2] repoman: declare '-x', '--xmlparse' command line options obsolete
Date: Mon, 23 May 2016 04:59:51
Message-Id: 1463979579-31144-1-git-send-email-gokturk@gentoo.org
1 Repoman pulls in lxml unconditionally now and performs metadata checks
2 by default. This behavior makes these command line options obsolete
3 since forcing the default makes little sense. Declare them obsolete
4 instead of removing them for backwards compatibility.
5 ---
6 repoman/man/repoman.1 | 2 +-
7 repoman/pym/repoman/argparser.py | 4 +++-
8 2 files changed, 4 insertions(+), 2 deletions(-)
9
10 diff --git a/repoman/man/repoman.1 b/repoman/man/repoman.1
11 index e2b9c66..88b3e5e 100644
12 --- a/repoman/man/repoman.1
13 +++ b/repoman/man/repoman.1
14 @@ -60,7 +60,7 @@ Be less verbose about extraneous info
15 Don't commit or fix anything; just show what would be done
16 .TP
17 \fB-x\fR, \fB--xmlparse\fR
18 -Forces the metadata.xml parse check to be carried out
19 +(OBSOLETE, always enabled) Forces the metadata.xml parse check to be carried out
20 .TP
21 \fB-v\fR, \fB--verbose\fR
22 Displays every package name while checking
23 diff --git a/repoman/pym/repoman/argparser.py b/repoman/pym/repoman/argparser.py
24 index 2d56a87..32758aa 100644
25 --- a/repoman/pym/repoman/argparser.py
26 +++ b/repoman/pym/repoman/argparser.py
27 @@ -117,7 +117,9 @@ def parse_args(argv, qahelp, repoman_default_opts):
28 parser.add_argument(
29 '-x', '--xmlparse', dest='xml_parse', action='store_true',
30 default=False,
31 - help='forces the metadata.xml parse check to be carried out')
32 + help=(
33 + '(OBSOLETE, always enabled) '
34 + 'forces the metadata.xml parse check to be carried out'))
35
36 parser.add_argument(
37 '--if-modified', choices=('y', 'n'), default='n',
38 --
39 2.7.3

Replies