Re: [gentoo-portage-dev] [PATCH 01/14] Use public API: hashfunc_map -> get_valid_checksum_keys()

[Michał Górny]

W dniu 12.03.2017, nie o godzinie 13∶36 -0700, użytkownik Zac Medico
napisał:
> On Sun, Mar 12, 2017 at 11:59 AM, Michał Górny <mgorny@g.o> wrote:
> > Use get_valid_checksum_keys() function instead of accessing hashfunc_map
> > directly throughout the Portage.
> > ---
> >  pym/portage/_emirrordist/FetchTask.py |  2 +-
> >  pym/portage/dbapi/bintree.py          |  4 ++--
> >  pym/portage/eclass_cache.py           |  2 +-
> >  pym/portage/manifest.py               |  4 ++--
> >  pym/portage/package/ebuild/fetch.py   | 10 +++++-----
> >  5 files changed, 11 insertions(+), 11 deletions(-)
> >
> > diff --git a/pym/portage/_emirrordist/FetchTask.py b/pym/portage/_emirrordist/FetchTask.py
> > index 64de67582..203b8c213 100644
> > --- a/pym/portage/_emirrordist/FetchTask.py
> > +++ b/pym/portage/_emirrordist/FetchTask.py
> > @@ -574,7 +574,7 @@ class FetchTask(CompositeTask):
> >                 else:
> >                         for hash_name in self.digests:
> >                                 if hash_name != "size" and \
> > -                                       hash_name in portage.checksum.hashfunc_map:
> > +                                       hash_name in portage.checksum.get_valid_checksum_keys():
>
> The get_valid_checksum_keys function creates a list for each call, so
> this is a lot less efficient that dict hash table lookup that it was
> before.

Does it really matter though? AFAICS this is just a matter of optimizing
the function, e.g. putting the keys in a frozenset.

-- 
Best regards,
Michał Górny