Archives
Archives
| From: | Zac Medico <zmedico@g.o> | ||
|---|---|---|---|
| To: | gentoo-portage-dev@l.g.o | ||
| Subject: | Re: [gentoo-portage-dev] [PATCH] make.defaults: negative incrementals in USE_EXPAND (530222) | ||
| Date: | Thu, 27 Nov 2014 09:09:42 | ||
| Message-Id: | 5476EA52.4050100@gentoo.org | ||
| In Reply to: | Re: [gentoo-portage-dev] [PATCH] make.defaults: negative incrementals in USE_EXPAND (530222) by Brian Dolbec |
||
| 1 | On 11/26/2014 11:46 PM, Brian Dolbec wrote: |
| 2 | > This code looks fine. As for the test, I know you know what you are |
| 3 | > doing :) |
| 4 | > |
| 5 | > LGTM |
| 6 | |
| 7 | Thank you. I've pushed a simplified version of the same patch: |
| 8 | |
| 9 | https://github.com/gentoo/portage/commit/b9c06a6a2dd4ccc875f8b9dd3139ea582e1e5621 |
| 10 | |
| 11 | My first attempt at simplifying it unexpectedly broke the test in |
| 12 | pym/portage/tests/ebuild/test_doebuild_fd_pipes.py: |
| 13 | |
| 14 | https://travis-ci.org/gentoo/portage/builds/42280811 |
| 15 | |
| 16 | I'm really curious about how such a strange result could be triggered... |
| 17 | -- |
| 18 | Thanks, |
| 19 | Zac |