Re: [gentoo-portage-dev] [PATCH v2] Add --output-style option to repoman

[Alec Warner]

On Thu, Feb 13, 2014 at 12:19 AM, Mike Frysinger <vapier@g.o> wrote:

> On Monday, February 10, 2014 20:22:36 Chris Reffett wrote:
> > This patch adds a --output-style option to repoman, which gives the user
> > a choice of output formats for the repoman checks. Choices are "default"
> > (current style) and "column" (a greppable format), but it should be easy
> > to add more. Fixes bug 481584.
>
> i'd expect a proper structured output would make sense to include in the
> default set.  like JSON.  just create a dict and send it to json.dump().
>

He didn't want to, and I didn't want to make him ;)


>
> > v2: Fix docstring to be complete and in the standard format, make use of
> > default choices in --output-style wrt comments by antarus and dol-sen
>
> erm, i thought the previous docstring was correct.  it followed PEP257
> while
> this new one is like javadoc or something.
>
> > -utilities.format_qa_output(f, stats, fails, dofull, dofail, options,
> > qawarnings)
> > +if options.output_style == 'column':
> > +     utilities.format_qa_output_column(f, stats, fails, dofull, dofail,
> > options, qawarnings)
> > +else:
> > +     utilities.format_qa_output(f, stats, fails, dofull, dofail,
> options,
> > qawarnings)
>
> use a func pointer instead.
> format_outputs = {
>         'column': utilities.format_qa_output_column,
>         'default': utilities.format_qa_output,
> }
> format_output = format_outputs.get(options.output_style,
>         format_outputs['default'])
> format_output(f, stats, fails, dofull, dofail, options, qawarnings)
>
> > +             formatter.add_literal_data("NumberOf " + category + " ")
>
> prefer to use % rather than + like so:
>         'NumberOf %s ' % category
>
> > +             formatter.add_literal_data("%s" % number)
>
> str(number)
>

That is the definition of %s, no explicit str() is necessary.

http://docs.python.org/2/library/stdtypes.html#string-formatting-operations


> -mike