Gentoo Archives: gentoo-portage-dev

From: Zac Medico <zmedico@g.o>
To: gentoo-portage-dev@l.g.o
Cc: Zac Medico <zmedico@g.o>
Subject: [gentoo-portage-dev] [PATCH] _backtrack_depgraph: fix premature backtracking termination (bug 693242)
Date: Sun, 01 Sep 2019 00:33:36
Message-Id: 20190901003118.6286-1-zmedico@gentoo.org
1 Make backtracking continue as long as the backtracker has remaining
2 nodes to explore. This fixes a case where it would terminate prematurely
3 when the depgraph.need_restart() method returned False, even though the
4 backtracker had remaining nodes to explore.
5
6 Bug: https://bugs.gentoo.org/693242
7 Signed-off-by: Zac Medico <zmedico@g.o>
8 ---
9 lib/_emerge/depgraph.py | 4 ++--
10 1 file changed, 2 insertions(+), 2 deletions(-)
11
12 diff --git a/lib/_emerge/depgraph.py b/lib/_emerge/depgraph.py
13 index 3e99ac077..08240af67 100644
14 --- a/lib/_emerge/depgraph.py
15 +++ b/lib/_emerge/depgraph.py
16 @@ -9794,8 +9794,8 @@ def _backtrack_depgraph(settings, trees, myopts, myparams, myaction, myfiles, sp
17 elif mydepgraph.need_restart():
18 backtracked += 1
19 backtracker.feedback(mydepgraph.get_backtrack_infos())
20 - else:
21 - break
22 + elif backtracker:
23 + backtracked += 1
24
25 if not (success or mydepgraph.need_config_change()) and backtracked:
26
27 --
28 2.21.0