Gentoo Archives: gentoo-portage-dev

From: "Göktürk Yüksek" <gokturk@g.o>
To: gentoo-portage-dev@l.g.o
Subject: [gentoo-portage-dev] [PATCH] repoman: declare '-x', '--xmlparse' command line options obsolete
Date: Thu, 19 May 2016 22:45:42
Message-Id: 1463697929-10480-1-git-send-email-gokturk@gentoo.org
1 Repoman pulls in lxml unconditionally now and performs metadata checks
2 by default. This behavior makes these command line options obsolete
3 since forcing the default makes little sense. Declare them obsolete
4 instead of removing them for backwards compatibility.
5
6 Signed-off-by: Göktürk Yüksek <gokturk@g.o>
7 ---
8 repoman/man/repoman.1 | 3 +--
9 repoman/pym/repoman/argparser.py | 2 +-
10 2 files changed, 2 insertions(+), 3 deletions(-)
11
12 diff --git a/repoman/man/repoman.1 b/repoman/man/repoman.1
13 index e2b9c66..fc5c52d 100644
14 --- a/repoman/man/repoman.1
15 +++ b/repoman/man/repoman.1
16 @@ -59,8 +59,7 @@ Be less verbose about extraneous info
17 \fB-p\fR, \fB--pretend\fR
18 Don't commit or fix anything; just show what would be done
19 .TP
20 -\fB-x\fR, \fB--xmlparse\fR
21 -Forces the metadata.xml parse check to be carried out
22 +\fB-x\fR, \fB--xmlparse\fR (OBSOLETE)
23 .TP
24 \fB-v\fR, \fB--verbose\fR
25 Displays every package name while checking
26 diff --git a/repoman/pym/repoman/argparser.py b/repoman/pym/repoman/argparser.py
27 index 2d56a87..3d35b6a 100644
28 --- a/repoman/pym/repoman/argparser.py
29 +++ b/repoman/pym/repoman/argparser.py
30 @@ -117,7 +117,7 @@ def parse_args(argv, qahelp, repoman_default_opts):
31 parser.add_argument(
32 '-x', '--xmlparse', dest='xml_parse', action='store_true',
33 default=False,
34 - help='forces the metadata.xml parse check to be carried out')
35 + help='(OBSOLETE)')
36
37 parser.add_argument(
38 '--if-modified', choices=('y', 'n'), default='n',
39 --
40 2.7.3

Replies