| 1 |
On 02/19/2014 02:50 PM, Brian Dolbec wrote: |
| 2 |
> |
| 3 |
> Really |
| 4 |
> ? don't use os.system() It is nearly obsolete. use subprocess.call() |
| 5 |
> or Popen(). call() is a direct sub. Use Popen for piping output... |
| 6 |
> |
| 7 |
|
| 8 |
Good point, I'll switch over. |
| 9 |
|
| 10 |
> Also, it would be better to call emerge with all pkgs in one command. |
| 11 |
> I know it will rarely be more than 1, maybe 2 but, emerge is slow |
| 12 |
> enough just intitializing. |
| 13 |
|
| 14 |
Yep, makes sense. |
| 15 |
|
| 16 |
> You might also want to turn off the progressbar for fix unless you |
| 17 |
> intend to pipe emerge's output and hide it. I might be inclined to |
| 18 |
> just run emerge in minimum output mode. It will display what it is |
| 19 |
> doing and any more failed builds/merges. I know I had the other |
| 20 |
> modules output the data without displaying and let the cli handle any |
| 21 |
> display. We should be able to do similar to the progressbar, and |
| 22 |
> connect the emerge stdout pipe to a display code. That way any other |
| 23 |
> frontend could do with the output what they like. |
| 24 |
|
| 25 |
I'll disable the progressbar for fix(), and look more into minimizing |
| 26 |
emerge output. |
| 27 |
|
| 28 |
Regards, |
| 29 |
Pavel |
Archives