| 1 |
Please find the patch split into three smaller patch: |
| 2 |
* refactoring: contains the Michal's suggestions. I also removed the |
| 3 |
whitespace changes. |
| 4 |
* profile attributes export: same as in the previous patch |
| 5 |
* profile-env patch: uses "has" to check if profile-env is set. I also |
| 6 |
included the documentation in portage.5. |
| 7 |
|
| 8 |
The Change-Id git hook was disabled for this round of patches ;) |
| 9 |
|
| 10 |
Bertrand |
| 11 |
|
| 12 |
|
| 13 |
On Wed, Sep 17, 2014 at 2:57 PM, Bertrand Simonnet <bsimonnet@××××××.com> |
| 14 |
wrote: |
| 15 |
|
| 16 |
> Michal, not opposed to splitting the patch into three parts. |
| 17 |
> |
| 18 |
> I'd rather use the env/ mechanism instead of the package.env one as it is |
| 19 |
> more flexible. |
| 20 |
> It also feels better as ebuild.sh will walk the profiles to source the |
| 21 |
> bashrc script so a bashrc from a |
| 22 |
> "low priority" profile may override a package.env definition from a high |
| 23 |
> priority profile. |
| 24 |
> |
| 25 |
> I'll remove the with spaces and the Change-Id (gerrit specific tag I |
| 26 |
> believe) |
| 27 |
> |
| 28 |
> Bertrand |
| 29 |
> |
| 30 |
> |
| 31 |
> On Wed, Sep 17, 2014 at 2:43 PM, Zac Medico <zmedico@g.o> wrote: |
| 32 |
> |
| 33 |
>> On 09/17/2014 02:28 PM, Michał Górny wrote: |
| 34 |
>> >> diff --git a/pym/portage/repository/config.py |
| 35 |
>> b/pym/portage/repository/config.py |
| 36 |
>> >> index 5e0d055..ef8054e 100644 |
| 37 |
>> >> --- a/pym/portage/repository/config.py |
| 38 |
>> >> +++ b/pym/portage/repository/config.py |
| 39 |
>> >> @@ -40,7 +40,7 @@ if sys.hexversion >= 0x3000000: |
| 40 |
>> >> _invalid_path_char_re = re.compile(r'[^a-zA-Z0-9._\-+:/]') |
| 41 |
>> >> |
| 42 |
>> >> _valid_profile_formats = frozenset( |
| 43 |
>> >> - ['pms', 'portage-1', 'portage-2']) |
| 44 |
>> >> + ['pms', 'portage-1', 'portage-2', 'profile-env']) |
| 45 |
>> > |
| 46 |
>> > I'm not sure if dedicated profile format is the best way to go. If I |
| 47 |
>> > understand your patch correctly, this means that 'profile-env' has only |
| 48 |
>> > features of PMS profile but not of 'portage-*' formats. This could mean |
| 49 |
>> > that some people would have to choose between features of one or |
| 50 |
>> > the other. Since both are compatible, i suggest 'portage-3' instead. |
| 51 |
>> |
| 52 |
>> The profile-formats field is designed to allow mixing of formats. So, |
| 53 |
>> it's legal to mix profile-env with any of the other formats. |
| 54 |
>> -- |
| 55 |
>> Thanks, |
| 56 |
>> Zac |
| 57 |
>> |
| 58 |
>> |
| 59 |
> |
Archives