Gentoo Archives: gentoo-portage-dev

From: Brian Dolbec <dolsen@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] Re: [PATCH] emerge: add --changed-deps/--binpkg-changed-deps (282927)
Date: Thu, 15 Jan 2015 00:59:46
Message-Id: 20150114165926.05ec0efb.dolsen@gentoo.org
In Reply to: [gentoo-portage-dev] Re: [PATCH] emerge: add --changed-deps/--binpkg-changed-deps (282927) by Zac Medico
1 On Wed, 14 Jan 2015 15:26:49 -0800
2 Zac Medico <zmedico@g.o> wrote:
3
4 > On 12/23/2014 12:45 PM, Zac Medico wrote:
5 > > The @changed-deps set is useful, but it has limitations similar to
6 > > the @installed set (see bug #387059), which can make it unsuitable
7 > > for use when updating the whole system. Therefore, implement two
8 > > new options that are analogous to --newuse and
9 > > --binpkg-respect-use, called --changed-deps and
10 > > --binpkg-changed-deps.
11 > >
12 > > The rationale for having a separate --binpkg-* option is the same in
13 > > both cases: depending on the situation, people may want different
14 > > behavior for binary packages. For example, just like
15 > > ---binpkg-respect-use is automatically enabled if the user has not
16 > > specified --usepkgonly, so is --binpkg-changed-deps (though the user
17 > > can explicitly override the automatic behavior). In both cases,
18 > > inconsistencies in dependencies are automatically avoided,
19 > > increasing the probability of a successful dependency calculation.
20 > >
21 > > X-Gentoo-Bug: 282927
22 > > X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=282927
23 > > ---
24 > > man/emerge.1 | 22 +++-
25 > > pym/_emerge/create_depgraph_params.py | 16 +++
26 > > pym/_emerge/depgraph.py | 138
27 > > ++++++++++++++++++++++--
28 > > pym/_emerge/main.py | 26 +++++
29 > > pym/portage/dep/_slot_operator.py | 13 +++
30 > > pym/portage/tests/resolver/test_changed_deps.py | 120
31 > > +++++++++++++++++++++ 6 files changed, 323 insertions(+), 12
32 > > deletions(-) create mode 100644
33 > > pym/portage/tests/resolver/test_changed_deps.py
34 >
35 > Any feedback on this? I think it's good to merge.
36
37 yeah, looks good, merge approved :)
38
39 --
40 Brian Dolbec <dolsen>