Gentoo Archives: gentoo-portage-dev

From: Zac Medico <zmedico@g.o>
To: gentoo-portage-dev@l.g.o, "Michał Górny" <mgorny@g.o>
Subject: Re: [gentoo-portage-dev] [PATCH] Remove remaining herd support logic and checks
Date: Wed, 07 Feb 2018 20:34:32
Message-Id: 603a2a40-fc1f-14f1-2b9d-7c6a29c23291@gentoo.org
In Reply to: [gentoo-portage-dev] [PATCH] Remove remaining herd support logic and checks by "Michał Górny"
1 On 02/07/2018 01:46 AM, Michał Górny wrote:
2 > diff --git a/pym/portage/xml/metadata.py b/pym/portage/xml/metadata.py
3 > index 9e48dddde..99e0474c1 100644
4 > --- a/pym/portage/xml/metadata.py
5 > +++ b/pym/portage/xml/metadata.py
6 > @@ -1,4 +1,4 @@
7 > -# Copyright 2010-2017 Gentoo Foundation
8 > +# Copyright 2010-2018 Gentoo Foundation
9 > # Distributed under the terms of the GNU General Public License v2
10 >
11 > """Provides an easy-to-use python interface to Gentoo's metadata.xml file.
12 > @@ -8,8 +8,6 @@
13 > >>> pkg_md = MetaDataXML('/usr/portage/app-misc/gourmet/metadata.xml')
14 > >>> pkg_md
15 > <MetaDataXML '/usr/portage/app-misc/gourmet/metadata.xml'>
16 > - >>> pkg_md.herds()
17 > - ['no-herd']
18 > >>> for maint in pkg_md.maintainers():
19 > ... print "{0} ({1})".format(maint.email, maint.name)
20 > ...
21 > @@ -198,13 +196,11 @@ class _Upstream(object):
22 > class MetaDataXML(object):
23 > """Access metadata.xml"""
24 >
25 > - def __init__(self, metadata_xml_path, herds):
26 > + def __init__(self, metadata_xml_path):
27
28 For backward compatibility, lets make herds an unused
29 herds=DeprecationWarning keyword argument.
30
31 Otherwise, the patch looks good.
32 --
33 Thanks,
34 Zac

Attachments

File name MIME type
signature.asc application/pgp-signature