Re: [gentoo-portage-dev] [PATCH] sync.py: set returncode when task failed in SyncScheduler._task_exit()

[Zac Medico]

On 01/26/2017 11:00 AM, Alexandru Elisei wrote:
> If task.returncode is not os.EX_OK then returncode isn't defined when
> trying to append the (repo, returncode) tuple to self.retvals. This will
> raise an UnboundLocalError exception.
>
> This reverts the changes to the function made by commit f143e58.
> ---
>  pym/portage/emaint/modules/sync/sync.py | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/pym/portage/emaint/modules/sync/sync.py
> b/pym/portage/emaint/modules/sync/sync.py
> index b190b3c..076297a 100644
> --- a/pym/portage/emaint/modules/sync/sync.py
> +++ b/pym/portage/emaint/modules/sync/sync.py
> @@ -362,6 +362,7 @@ class SyncScheduler(AsyncScheduler):
>  		# that hooks will be called in a backward-compatible manner
>  		# even if all sync tasks have failed.
>  		hooks_enabled = True
> +		returncode = task.returncode
>  		if task.returncode == os.EX_OK:
>  			returncode, message, updatecache_flg, hooks_enabled = task.result
>  			if message:
>

Thanks, applied:

https://gitweb.gentoo.org/proj/portage.git/commit/?id=9305bccfb29807f54a9dc514d3aea70639eb2c49
-- 
Thanks,
Zac