Gentoo Archives: gentoo-portage-dev

From: Zac Medico <zmedico@g.o>
To: gentoo-portage-dev@l.g.o
Cc: alexandru.elisei@×××××.com
Subject: Re: [gentoo-portage-dev] [PATCH] emerge: sync given repos even if auto-sync is false
Date: Tue, 21 Feb 2017 01:40:14
Message-Id: 25596f20-3a78-14fa-1c25-077747bd79af@gentoo.org
In Reply to: [gentoo-portage-dev] [PATCH] emerge: sync given repos even if auto-sync is false by Alexandru Elisei
1 On 02/20/2017 09:53 AM, Alexandru Elisei wrote:
2 > ---
3 > #
4 > # This will be followed by a series of patches to ignore repos with sync-type
5 > # unset, as per the man page, fail when sync-uri is not specified and an update
6 > # to the emerge.1 man page to reflect the change in behavior.
7 > #
8 > pym/_emerge/actions.py | 8 +++++--
9 > pym/portage/emaint/modules/sync/sync.py | 40 ++++-----------------------------
10 > 2 files changed, 10 insertions(+), 38 deletions(-)
11 >
12 > diff --git a/pym/_emerge/actions.py b/pym/_emerge/actions.py
13 > index 71e362e..cc0269d 100644
14 > --- a/pym/_emerge/actions.py
15 > +++ b/pym/_emerge/actions.py
16 > @@ -1999,9 +1999,13 @@ def action_sync(emerge_config, trees=DeprecationWarning,
17 > action=action, args=[], trees=trees, opts=opts)
18 >
19 > syncer = SyncRepos(emerge_config)
20 > -
21 > return_messages = "--quiet" not in emerge_config.opts
22 > - success, msgs = syncer.auto_sync(options={'return-messages': return_messages})
23 > + options = {'return-messages' : return_messages}
24 > + if emerge_config.args:
25 > + options['repo'] = emerge_config.args
26 > + success, msgs = syncer.repo(options=options)
27 > + else:
28 > + success, msgs = syncer.auto_sync(options=options)
29 > if return_messages:
30 > print_results(msgs)
31 >
32
33 The above change works fine by itself, so I've merged it in this commit:
34
35 https://gitweb.gentoo.org/proj/portage.git/commit/?id=75f0936b8866b143643abcd6c302cd72fc71eef3
36
37 The changes to sync-type and sync-uri validation can go in separately.
38 --
39 Thanks,
40 Zac