Gentoo Archives: gentoo-portage-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-portage-dev@l.g.o
Cc: Fabian Groffen <grobian@g.o>
Subject: Re: [gentoo-portage-dev] [PATCH] lib/portage/dbapi/vartree: use dynamic report interval in _collision_protect
Date: Mon, 07 Jan 2019 19:05:40
Message-Id: 1546887921.860.16.camel@gentoo.org
In Reply to: [gentoo-portage-dev] [PATCH] lib/portage/dbapi/vartree: use dynamic report interval in _collision_protect by Fabian Groffen
1 On Mon, 2019-01-07 at 15:31 +0100, Fabian Groffen wrote:
2 > The reporting of files remaining can look somewhat odd since the report
3 > interval is hardcoded to be per 1000 objects. Adjust this interval to
4 > be regular towards the end. While at it, report percentage done.
5 >
6 > Output before this patch:
7 >
8 > * checking 6111 files for package collisions
9 > 5111 files remaining ...
10 > 4111 files remaining ...
11 > 3111 files remaining ...
12 > 2111 files remaining ...
13 > 1111 files remaining ...
14 > 111 files remaining ...
15 >
16 > After:
17 >
18 > * checking 6158 files for package collisions
19 > 16% done, 5131 files remaining ...
20 > 33% done, 4104 files remaining ...
21 > 50% done, 3077 files remaining ...
22 > 66% done, 2050 files remaining ...
23 > 83% done, 1023 files remaining ...
24 >
25
26 Not saying it's necessary but could we have some final message here?
27 I find it a bit weird to end at 83%.
28
29 --
30 Best regards,
31 Michał Górny

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies