Gentoo Archives: gentoo-portage-dev

From: "M. J. Everitt" <m.j.everitt@×××.org>
To: gentoo-portage-dev@l.g.o, Zac Medico <zmedico@g.o>
Subject: Re: [gentoo-portage-dev] [PATCH] XARGS: use gxargs for USERLAND=BSD (bug 663256)
Date: Thu, 09 Aug 2018 23:17:58
Message-Id: 524ab439-82fc-865c-949c-fbb55fc41e9e@iee.org
In Reply to: [gentoo-portage-dev] [PATCH] XARGS: use gxargs for USERLAND=BSD (bug 663256) by Zac Medico
1 On 10/08/18 00:04, Zac Medico wrote:
2 > For USERLAND=BSD, set XARGS="gxargs -r" if gxargs is available,
3 > so the code from bug 630292 works for USERLAND=BSD.
4 >
5 > Fixes: 50283f1abb77 (install-qa-check.d/60pngfix: parallel support (bug 630292))
6 > Reported-by: Michał Górny <mgorny@g.o>
7 > Bug: https://bugs.gentoo.org/663256
8 > ---
9 > bin/isolated-functions.sh | 6 +++++-
10 > 1 file changed, 5 insertions(+), 1 deletion(-)
11 >
12 > diff --git a/bin/isolated-functions.sh b/bin/isolated-functions.sh
13 > index 28ca94532..cac42a4c5 100644
14 > --- a/bin/isolated-functions.sh
15 > +++ b/bin/isolated-functions.sh
16 > @@ -448,7 +448,11 @@ fi
17 > if [[ -z ${XARGS} ]] ; then
18 > case ${USERLAND} in
19 > BSD)
20 > - export XARGS="xargs"
21 > + if type -P gxargs > /dev/null; then
22 > + export XARGS="gxargs -r"
23 > + else
24 > + export XARGS="xargs"
25 > + fi
26 > ;;
27 > *)
28 > export XARGS="xargs -r"
29 Isn't the else clause there redundant?

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies

Subject Author
Re: [gentoo-portage-dev] [PATCH] XARGS: use gxargs for USERLAND=BSD (bug 663256) "M. J. Everitt" <m.j.everitt@×××.org>