1 |
-----BEGIN PGP SIGNED MESSAGE-----
|
2 |
Hash: SHA512
|
3 |
|
4 |
On Mon, 11 Jan 2016 16:39:27 +0100
|
5 |
Alexander Berntsen <bernalex@g.o> wrote:
|
6 |
|
7 |
> I read through these ages ago, and I think you've incorporated my |
8 |
> feedback from back then. But like back then, I don't have too much |
9 |
> feedback to offer as this is certainly not an area of Portage I'm |
10 |
> nearly as familiar with as you are. It mostly just LGTM. |
11 |
> |
12 |
> There are some minor issues with commit messages. Like how they |
13 |
> randomly don't have full stops in some sentences for some reason. |
14 |
> "fetches.py: Create new isVcsDir() in the vcs plugins" says "teh" |
15 |
> instead of "the". |
16 |
> |
17 |
> ThirdPartyMirrors is a bit low on documentation. |
18 |
> |
19 |
> I expect Zac will be of far more help than me. In any event, thanks a |
20 |
> lot for working on this! |
21 |
> |
22 |
> |
23 |
> You asked about a release on IRC -- did you want to get a release out |
24 |
> before merging this? I would be fine with either way. Let me know what |
25 |
> you need from me, and I'll get on it ASAP. |
26 |
> - -- |
27 |
> Alexander |
28 |
> bernalex@g.o |
29 |
> https://secure.plaimi.net/~alexander |
30 |
> |
31 |
|
32 |
|
33 |
Zac, I'm done with code changes in the rewrite. Ready for a last look
|
34 |
before a merge. Can you have a look again? I did some changes/fixes
|
35 |
and rebased them in. Floppym hasn't reported any more bugs, so I think
|
36 |
it's ready for broader testing in a release. Then we can work on
|
37 |
moving all the test data to a separate file in the tree or downloaded...
|
38 |
|
39 |
|
40 |
I am just trying to get the docstrings done and then merge.
|
41 |
|
42 |
- --
|
43 |
Brian Dolbec <dolsen>
|
44 |
|
45 |
-----BEGIN PGP SIGNATURE-----
|
46 |
Version: GnuPG v2.1
|
47 |
|
48 |
iQJ8BAEBCgBmBQJW21GBXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
|
49 |
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNUQ3Qzc0RTA4MUNDNzBEQjRBNEFBRjVG
|
50 |
QkJEMDg3Mjc1ODIwRUQ4AAoJEPu9CHJ1gg7YUbEQAKCx30TOiuIwMiRU4Sp+8XqJ
|
51 |
05K20eRfidQYvnfLp/7jnpBcB1l2yjqdcC1EQCS9DeFuGsmQQd62Ggq14S2HvC2F
|
52 |
jKF9DoQZaXOD/2l+CmE3xKkS88ksXsEzN/vm8DSAJsyc7cux/lvXUYS1fRd10DA6
|
53 |
skWTz985u72tAvAgZoAaUx1kx+6Ugy63aegjAf0Zitw16v72bDff+fDYjC8Ev0dk
|
54 |
gCgzjJ8VI1DDxz8NWR2V6keRn27fHqBFWTRYlGfXErbMpbPhA/+iQwyphPZLkT6I
|
55 |
q7wnFIc+qP4sJN3997c2wo523eRlYchWZdK5tDe8VXM9c0J+KB0GqEvE5Y5QS21E
|
56 |
HmInRQJm5YjfwhNm7Lv5dvrQKA2SgMaMjPtPPpmXrTCosKFeJ5LBfsh5yvfwUXLZ
|
57 |
N691rqqfro97vIGd7GKDbLIKqfjYf28FB9NCsPmh+Y+0BEb18bkoZwB1HkuWiqjQ
|
58 |
kdI9IJqMuFd6rbIUU8ONdYyBdG1rv+G01zFZSXuTYacNVUC2W+Nc1LTbil1FW7S2
|
59 |
mzYplnVHfjjfKgCcRbxOzOFe4drv03Ek12DwT+Oj/r5l0Kz+V3tWtLLYbRiJCS7b
|
60 |
YBZNijNLHAG/GOTCq5eNpnjc+n7R0zRWtsbxl861kpyQHvrYs+R8VSC25zooKPYr
|
61 |
AXWn0HjAAYOkwDRjkBjl
|
62 |
=LQn3
|
63 |
-----END PGP SIGNATURE----- |