Gentoo Archives: gentoo-portage-dev

From: Brian Dolbec <dolsen@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH] XARGS: use gxargs for USERLAND=BSD (bug 663256)
Date: Thu, 09 Aug 2018 23:57:00
Message-Id: 20180809165657.224e5a0e@professor-x
In Reply to: [gentoo-portage-dev] [PATCH] XARGS: use gxargs for USERLAND=BSD (bug 663256) by Zac Medico
1 On Thu, 9 Aug 2018 16:04:42 -0700
2 Zac Medico <zmedico@g.o> wrote:
3
4 > For USERLAND=BSD, set XARGS="gxargs -r" if gxargs is available,
5 > so the code from bug 630292 works for USERLAND=BSD.
6 >
7 > Fixes: 50283f1abb77 (install-qa-check.d/60pngfix: parallel support
8 > (bug 630292)) Reported-by: Michał Górny <mgorny@g.o>
9 > Bug: https://bugs.gentoo.org/663256
10 > ---
11 > bin/isolated-functions.sh | 6 +++++-
12 > 1 file changed, 5 insertions(+), 1 deletion(-)
13 >
14 > diff --git a/bin/isolated-functions.sh b/bin/isolated-functions.sh
15 > index 28ca94532..cac42a4c5 100644
16 > --- a/bin/isolated-functions.sh
17 > +++ b/bin/isolated-functions.sh
18 > @@ -448,7 +448,11 @@ fi
19 > if [[ -z ${XARGS} ]] ; then
20 > case ${USERLAND} in
21 > BSD)
22 > - export XARGS="xargs"
23 > + if type -P gxargs > /dev/null; then
24 > + export XARGS="gxargs -r"
25 > + else
26 > + export XARGS="xargs"
27 > + fi
28 > ;;
29 > *)
30 > export XARGS="xargs -r"
31
32 LGTM