Gentoo Archives: gentoo-portage-dev

From: SebastianLuther@×××.de
To: gentoo-portage-dev@l.g.o
Subject: [gentoo-portage-dev] [PATCH] QA warning for files in /var/{cache,lib,lock,run}/ or /run/ (bug 493154)
Date: Thu, 05 Dec 2013 20:57:32
Message-Id: 1386277037-9492-1-git-send-email-SebastianLuther@gmx.de
1 From: Sebastian Luther <SebastianLuther@×××.de>
2
3 No warning will be issued if the directories are created, but are
4 left empty.
5
6 URL: https://bugs.gentoo.org/493154
7 ---
8 bin/misc-functions.sh | 5 +++++
9 1 file changed, 5 insertions(+)
10
11 diff --git a/bin/misc-functions.sh b/bin/misc-functions.sh
12 index bd99def..9e1a5ee 100755
13 --- a/bin/misc-functions.sh
14 +++ b/bin/misc-functions.sh
15 @@ -242,6 +242,11 @@ install_qa_check() {
16 [[ -d ${ED}/$x ]] && f+=" $x\n"
17 done
18
19 + # It's ok create these directories, but not to install into them. (bug 493154)
20 + for x in var/cache var/lib var/lock var/run run ; do
21 + [[ -d ${ED}/$x ]] && [[ $(find "${ED}/${x}" -prune -empty) = "" ]] && f+=" $x\n"
22 + done
23 +
24 if [[ -n $f ]] ; then
25 eqawarn "QA Notice: This ebuild installs into the following deprecated directories:"
26 eqawarn
27 --
28 1.8.3.2

Replies