Re: [gentoo-portage-dev] [PATCH] post_sync actions

[Jason Stubbs]

On Sunday 30 October 2005 11:04, Ned Ludd wrote:

> updated patch that adds error checking and shifts when we exexve to the
> end patch


+                       try:

+                               portage.spawn(portage.USER_CONFIG_PATH + "/bin/post_sync " + dosyncuri, portage.settings, free=1)

+                       except:

+                               print red(" * ")+bold("spawn failed of "+ portage.USER_CONFIG_PATH + "/bin/post_sync")



Please don't _ever_ use try/except without specifying exactly what Exception

your looking to catch. You should be looking at the return value rather than

if an Exception was raised in this case anyway.



--

Jason Stubbs



-- 

gentoo-portage-dev@g.o mailing list