Gentoo Archives: gentoo-portage-dev

From: Brian Dolbec <dolsen@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH v2 2/2] Add an emaint module that can scan for failed merges and that can fix failed merges.
Date: Fri, 11 Apr 2014 23:03:10
Message-Id: 20140411160300.226b9416.dolsen@gentoo.org
In Reply to: Re: [gentoo-portage-dev] [PATCH v2 2/2] Add an emaint module that can scan for failed merges and that can fix failed merges. by Pavel Kazakov
1 On Fri, 11 Apr 2014 15:05:09 -0700
2 Pavel Kazakov <nullishzero@g.o> wrote:
3
4 > On 03/31/2014 12:00 AM, Alexander Berntsen wrote:
5 > > On 31/03/14 04:06, Brian Dolbec wrote:
6 > >> It all looked really good to me. {:-D
7 > > Yep.
8 > >
9 > > Please update the commit messages to follow DEVELOPING though.
10 > >
11 >
12 > Sure. How are the following updates?
13 >
14 > For the first patch, I'll remove the second message line so the
15 > message is only:
16 > Move -MERGING- string to a constant
17 >
18 >
19
20 No, there is never suppose to be more than a blank line for the second
21 line. Then for lines 3+ fill your boots :)
22
23 the idea is to have one short descriptive line, followed by a blank
24 line, then as many detail lines as needed.
25
26 So, in this case dropping out the whitespace changes is minor, but
27 still relevant. so it should be kept on line 3.
28
29
30 > For the second patch, I'll update the message to:
31 > Add emaint module that handles failed merges
32 >
33 > The emaint module can scan for failed merges and fix any failed merges
34 > found. The emaint module also keeps track of failed merges using a
35 > tracking file.
36 >
37 > Regards,
38 > Pavel
39 >
40
41 I was thinking more along the lines of:
42
43 New emaint module: Merges
44
45 This emaint module scans for failed package merges and will display
46 or fix any failed packages found.
47 This module also saves failed merges found using a tracking file.
48 Subsequent runs of the module will re-load that info for re-display,
49 re-emerge of those packages.
50
51
52 --
53 Brian Dolbec <dolsen>

Replies