Gentoo Archives: gentoo-portage-dev

From: Zac Medico <zmedico@g.o>
To: gentoo-portage-dev@l.g.o, Michael 'veremitz' Everitt <gentoo@×××××××.xyz>
Subject: [gentoo-portage-dev] Re: RFC: [QA] notice with 'failed' seds [was PATCH: eapply drop -s option]
Date: Sun, 15 Dec 2019 21:29:10
Message-Id: f51e8f00-edf6-8ee4-a64e-3be879460b30@gentoo.org
In Reply to: [gentoo-portage-dev] RFC: [QA] notice with 'failed' seds [was PATCH: eapply drop -s option] by Michael 'veremitz' Everitt
1 On 12/13/19 2:12 PM, Michael 'veremitz' Everitt wrote:
2 > On 13/12/19 20:36, Michał Górny wrote [excerpted]:
3 >>
4 >> Is this really an argument for or *against* it? Developers are entirely
5 >> capable of keeping seds that do nothing for years, as well as patches
6 >> that -- while apparently applying correctly -- are entirely meaningless.
7 > <snip>
8 >
9 > I think there is some merit in some kind of feedback when sed's are doing
10 > nothing, although how feasible it is to generate any useful feedback I
11 > can't say. I wouldn't say it needs to explicitly fail or make lots of
12 > noise, just an info message that could prompt some further investigation.
13 >
14
15 It's possible to implement a sed wrapper that detects file arguments for
16 -i/--in-place mode, and compares file content before and after the sed call.
17
18 There are also ways to make sed exit with an error but that won't be as
19 easy to use as a sed wrapper:
20
21 https://stackoverflow.com/questions/15965073/return-code-of-sed-for-no-match/15966279
22 --
23 Thanks,
24 Zac

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies