1 |
On Wed, 15 Jan 2014 17:44:15 -0800 |
2 |
Alec Warner <antarus@g.o> wrote: |
3 |
|
4 |
> On Wed, Jan 15, 2014 at 4:07 PM, Tom Wijsman <tomwij@g.o> |
5 |
> wrote: |
6 |
> |
7 |
> > --- |
8 |
> > bin/repoman | 53 |
9 |
> > +++++++++++++++++++++++++++++++++++++++++++++++++++++ man/repoman.1 |
10 |
> > | 4 ++++ 2 files changed, 57 insertions(+) |
11 |
> > |
12 |
> > |
13 |
> I urge you to not author new checks like this. /usr/bin/repoman is |
14 |
> already a mess. |
15 |
> |
16 |
> Write these checks as functions, put them in a different file, and |
17 |
> just call them from the giant messy loop. At least that way the |
18 |
> checks are self contained (great for avoiding things like variable |
19 |
> re-use or shadowing). |
20 |
|
21 |
My plan is to first work a bit on repoman to get to know it, then when |
22 |
knowing better where everything is work on refactoring it. If I start |
23 |
to refactor right away, or start adding random files without knowing |
24 |
where everything is; I would create a more broken design than it is. |
25 |
|
26 |
Don't worry, I plan on a fully refactored Portage as well as good |
27 |
practices when adding new checks; which will definitely become |
28 |
necessary as we go forward. There's ~80 bugs, imagine all the code that |
29 |
that would bring; definitely don't want those files to grow much longer. |
30 |
|
31 |
-- |
32 |
With kind regards, |
33 |
|
34 |
Tom Wijsman (TomWij) |
35 |
Gentoo Developer |
36 |
|
37 |
E-mail address : TomWij@g.o |
38 |
GPG Public Key : 6D34E57D |
39 |
GPG Fingerprint : C165 AF18 AB4C 400B C3D2 ABF0 95B2 1FCD 6D34 E57D |