1 |
On 12/16/2015 09:49 AM, Michał Górny wrote: |
2 |
> On Wed, 16 Dec 2015 14:38:03 +0100 |
3 |
> Alexander Berntsen <bernalex@g.o> wrote: |
4 |
> |
5 |
>> -----BEGIN PGP SIGNED MESSAGE----- |
6 |
>> Hash: SHA512 |
7 |
>> |
8 |
>> On 16/12/15 06:33, Zac Medico wrote: |
9 |
>>> Disable Manifest "stable mtime" behavior by default, and add a |
10 |
>>> corresponding egencache option. |
11 |
>> This message tells me nothing about why we need to do this. |
12 |
> |
13 |
> We need do this because we changed the behavior and the new behavior is |
14 |
> counter-intuitive. We already had a number of bugs caused by it, |
15 |
> and while it's used by Infra, it's at least unexpected when someone |
16 |
> manually runs 'repoman manifest'. |
17 |
|
18 |
Just because it was historically buggy does not mean that it will always |
19 |
be that way. I believe that it will be very safe once we've fixed it to |
20 |
include the mtimes of all relevant directories in the max mtime calculation. |
21 |
|
22 |
> I mean, before this all started 'repoman manifest' just updated |
23 |
> the Manifest which meant it's mtime changed. Nowadays, it also sets |
24 |
> mtime to some value in the past, which means running 'repoman manifest' |
25 |
> may result in updated Manifest having mtime older than the old |
26 |
> Manifest. As a result, people using rsync are in trouble. And this has |
27 |
> been reported too by overlay owners. |
28 |
|
29 |
We should get our facts straight. It's not possible for the updated |
30 |
Manifest to have an older mtime than the old manifest, because the mtime |
31 |
of the old Manfiest is included in the max mtime calculation. |
32 |
-- |
33 |
Thanks, |
34 |
Zac |