Gentoo Archives: gentoo-portage-dev

From: Mike Gilbert <floppym@g.o>
To: gentoo-portage-dev@l.g.o
Subject: [gentoo-portage-dev] [PATCH] Revert "unpack: avoid useless chmods to improve speed"
Date: Sun, 27 Sep 2015 13:25:01
Message-Id: 1443360289-9536-1-git-send-email-floppym@gentoo.org
1 This reverts commit 0dc7b2a3923508896cf217f325b8339d73353553.
2
3 The "optimized" chmod is no longer recursive, which causes files to be
4 missed.
5
6 X-Gentoo-Bug: 561368
7 X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=561368
8 ---
9 bin/phase-helpers.sh | 4 ++--
10 1 file changed, 2 insertions(+), 2 deletions(-)
11
12 diff --git a/bin/phase-helpers.sh b/bin/phase-helpers.sh
13 index b446060..efd2cfa 100644
14 --- a/bin/phase-helpers.sh
15 +++ b/bin/phase-helpers.sh
16 @@ -531,8 +531,8 @@ unpack() {
17 done
18 # Do not chmod '.' since it's probably ${WORKDIR} and PORTAGE_WORKDIR_MODE
19 # should be preserved.
20 - find . -mindepth 1 '!' -type l '!' -perm /a+rX,u+w,g-w,o-w \
21 - -exec chmod -f a+rX,u+w,g-w,o-w '{}' +
22 + find . -mindepth 1 -maxdepth 1 ! -type l -print0 | \
23 + ${XARGS} -0 chmod -fR a+rX,u+w,g-w,o-w
24 }
25
26 econf() {
27 --
28 2.5.3

Replies