Gentoo Archives: gentoo-portage-dev

From: Zac Medico <zmedico@g.o>
To: gentoo-portage-dev@l.g.o, Mike Gilbert <floppym@g.o>
Subject: Re: [gentoo-portage-dev] [PATCH] process: redirect IPv6 'ip' command output to /dev/null
Date: Fri, 02 Aug 2019 17:49:27
Message-Id: 67385266-c18b-9329-f466-012b939bfddb@gentoo.org
In Reply to: [gentoo-portage-dev] [PATCH] process: redirect IPv6 'ip' command output to /dev/null by Mike Gilbert
1 On 8/2/19 9:06 AM, Mike Gilbert wrote:
2 > Bug: https://bugs.gentoo.org/691290
3 > Signed-off-by: Mike Gilbert <floppym@g.o>
4 > ---
5 > lib/portage/process.py | 4 +++-
6 > 1 file changed, 3 insertions(+), 1 deletion(-)
7 >
8 > diff --git a/lib/portage/process.py b/lib/portage/process.py
9 > index 77f7fac02..4d5a42a8c 100644
10 > --- a/lib/portage/process.py
11 > +++ b/lib/portage/process.py
12 > @@ -478,7 +478,9 @@ def _configure_loopback_interface():
13 >
14 > try:
15 > subprocess.call(['ip', 'address', 'add', '10.0.0.1/8', 'dev', 'lo'])
16 > - subprocess.call(['ip', 'address', 'add', 'fd00::1/8', 'dev', 'lo'])
17 > + with open('/dev/null', 'wb') as devnull:
18 > + subprocess.call(['ip', 'address', 'add', 'fd00::1/8', 'dev', 'lo'],
19 > + stdout=devnull, stderr=devnull)
20 > except OSError as e:
21 > writemsg("Error calling 'ip': %s\n" % e.strerror, noiselevel=-1)
22 >
23 >
24
25 Looks good, but let's use the os.devnull constant. Please merge.
26 --
27 Thanks,
28 Zac

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies