Gentoo Archives: gentoo-portage-dev

From: Zac Medico <zmedico@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] Re: [PATCH V2] emerge: check correctly for --sync success (bug 606588)
Date: Mon, 23 Jan 2017 01:29:46
Message-Id: 47cb39c6-6e3f-f56b-28c2-d65d6a747dfa@gentoo.org
In Reply to: [gentoo-portage-dev] Re: [PATCH V2] emerge: check correctly for --sync success (bug 606588) by Alexandru Elisei
1 On 01/20/2017 11:23 AM, Alexandru Elisei wrote:
2 > The class SyncRepos will keep a list of (repo, returncode) tuples.
3 > If sync is unsuccessful emerge will use this list to return the first
4 > failed repository return code.
5
6 I've pushed a minimal fix:
7
8 https://gitweb.gentoo.org/proj/portage.git/commit/?id=23f239134b0290cbe0435e13d8f1b1757c6d8524
9
10 It just returns 1 on failure. Would it really be useful to preserve the
11 returncode from the first failed repo? Probably not.
12 --
13 Thanks,
14 Zac

Replies