Gentoo Archives: gentoo-portage-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH] ecompress-file: Support decompressing .lz
Date: Sat, 17 Nov 2018 08:25:08
Message-Id: 1542443101.1106.1.camel@gentoo.org
In Reply to: Re: [gentoo-portage-dev] [PATCH] ecompress-file: Support decompressing .lz by Ulrich Mueller
1 On Sat, 2018-11-17 at 09:22 +0100, Ulrich Mueller wrote:
2 > > > > > > On Sat, 17 Nov 2018, Michał Górny wrote:
3 > > Signed-off-by: Michał Górny <mgorny@g.o>
4 > > ---
5 > > bin/ecompress-file | 3 +++
6 > > 1 file changed, 3 insertions(+)
7 > > diff --git a/bin/ecompress-file b/bin/ecompress-file
8 > > index bc8fe5451..ccc2701c3 100755
9 > > --- a/bin/ecompress-file
10 > > +++ b/bin/ecompress-file
11 > > @@ -29,6 +29,9 @@ compress_file() {
12 > > *.lzma|*.xz)
13 > > unxz -f "${x}" || __helpers_die "unxz failed"
14 > > x=${x%.*};;
15 > > + *.lz)
16 > > + lzip -df "${x}" || __helpers_die "lzip -d failed"
17 > > + x=${x%.lz};;
18 > > esac
19 >
20 >
21 > > filtered_args+=( "$x" )
22 > > --
23 > > 2.19.1
24 >
25 > Does that mean that portage will gain a dependency on lzip now?
26 >
27
28 No, I don't think that's necessary. That code is a cheap unsupported
29 hack that throws QA warnings. I need it to support corner case of
30 PORTAGE_COMPRESS=lzip FEATURES=binpkg-docompress old binpackages after
31 switching to FEATURES=-binpkg-docompress.
32
33 --
34 Best regards,
35 Michał Górny

Attachments

File name MIME type
signature.asc application/pgp-signature