Gentoo Archives: gentoo-portage-dev

From: Brian Dolbec <dolsen@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH] NewsManager.getUnreadItems: handle EROFS (490732)
Date: Mon, 10 Nov 2014 07:52:58
Message-Id: 20141109235156.08355576.dolsen@gentoo.org
In Reply to: [gentoo-portage-dev] [PATCH] NewsManager.getUnreadItems: handle EROFS (490732) by Zac Medico
1 On Sun, 9 Nov 2014 22:30:50 -0800
2 Zac Medico <zmedico@g.o> wrote:
3
4 > When getUnreadItems tries to lock the news.unread file, it's safe to
5 > ignore EROFS. This is handled with a ReadOnlyFileSystem exception
6 > raised from the portage.locks.lockfile function.
7 >
8 > X-Gentoo-Bug: 490732
9 > X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=490732
10 > ---
11 > pym/portage/exception.py | 1 +
12 > pym/portage/locks.py | 7 ++++++-
13 > pym/portage/news.py | 7 ++++---
14 > 3 files changed, 11 insertions(+), 4 deletions(-)
15 >
16 >...
17
18 > unread_lock = None
19 > try:
20 > unread_lock = lockfile(unread_filename,
21 > wantnewlockfile=1)
22 > - except (InvalidLocation, OperationNotPermitted,
23 > PermissionDenied):
24 > + except (InvalidLocation, OperationNotPermitted,
25 > PermissionDenied.
26 typo...........^
27
28 :)
29
30 > + ReadOnlyFileSystem):
31 > pass
32 > try:
33 > try:
34
35
36
37 --
38 Brian Dolbec <dolsen>

Replies