Gentoo Archives: gentoo-portage-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-portage-dev@l.g.o
Cc: "Michał Górny" <mgorny@g.o>
Subject: [gentoo-portage-dev] [PATCH] ebuild.sh: Explicitly ban get_libdir in global scope
Date: Wed, 30 Aug 2017 09:07:01
Message-Id: 20170830090652.21718-1-mgorny@gentoo.org
1 The value of get_libdir depends on the profile, and so it is not useful
2 for dependency calculations. Furthermore, it seems that Portage does
3 not handle defining it in global scope well due to EAPI checking magic.
4 Ban it completely where it is defined as EAPI function to let developers
5 catch their mistakes early rather than see them as 'command not found'
6 errors during dependency calculation / cache updates.
7
8 Bug: https://bugs.gentoo.org/629010
9 ---
10 bin/ebuild.sh | 1 +
11 1 file changed, 1 insertion(+)
12
13 diff --git a/bin/ebuild.sh b/bin/ebuild.sh
14 index a400ef72e..f1ac3f278 100755
15 --- a/bin/ebuild.sh
16 +++ b/bin/ebuild.sh
17 @@ -66,6 +66,7 @@ else
18 use useq usev use_with use_enable"
19 ___eapi_has_usex && funcs+=" usex"
20 ___eapi_has_in_iuse && funcs+=" in_iuse"
21 + ___eapi_has_get_libdir && funcs+=" get_libdir"
22 # These functions die because calls to them during the "depend" phase
23 # are considered to be severe QA violations.
24 funcs+=" best_version has_version portageq"
25 --
26 2.14.1

Replies