| 1 |
On Mon, 17 Feb 2014 02:49:24 -0500 |
| 2 |
Mike Frysinger <vapier@g.o> wrote: |
| 3 |
|
| 4 |
> On Sunday, February 16, 2014 20:57:29 David James wrote: |
| 5 |
> > On Fri, Feb 14, 2014 at 1:37 PM, Sebastian Luther wrote: |
| 6 |
> > > Am 14.02.2014 21:43, schrieb David James: |
| 7 |
> > > > Uploaded here: |
| 8 |
> > > > https://chromium-review.googlesource.com/#/c/186651/ |
| 9 |
> > > > |
| 10 |
> > > > You should be able to cherry-pick using this command: |
| 11 |
> > > > git fetch |
| 12 |
> > > > |
| 13 |
> > > > https://chromium.googlesource.com/chromiumos/third_party/portage_tool |
| 14 |
> > > > refs/changes/51/186651/1 && git cherry-pick FETCH_HEAD |
| 15 |
> > > |
| 16 |
> > > The patch has conflicts in depgraph.py. |
| 17 |
> > |
| 18 |
> > Rebased against latest master. I've also added a bunch of tests. |
| 19 |
> |
| 20 |
> LGTM |
| 21 |
> -mike |
| 22 |
|
| 23 |
Well, it looks fine looking at it from your review link. But I am |
| 24 |
unable to fetch it from your link to test. |
| 25 |
|
| 26 |
fatal: remote error: Git repository not found. |
| 27 |
|
| 28 |
Mike, if you can confirm the tests pass. Go ahead and merge it. |
| 29 |
|
| 30 |
-- |
| 31 |
Brian Dolbec <dolsen> |
Archives