1 |
On Mon, 29 Sep 2014 12:23:00 +0200 |
2 |
Alexander Berntsen <bernalex@g.o> wrote: |
3 |
|
4 |
> Turn off news-reading by default when --ask, and instead make it an |
5 |
> option --read-news. |
6 |
> |
7 |
> Apparently making --ask a bit more interactive was "goddamn stupid" |
8 |
> and ruined the lives of several Gentoo developers. Props to MichaĆ who |
9 |
> predicted this all along. |
10 |
> |
11 |
> Signed-off-by: Alexander Berntsen <bernalex@g.o> |
12 |
> --- |
13 |
> man/emerge.1 | 3 +++ |
14 |
> pym/_emerge/actions.py | 2 +- |
15 |
> pym/_emerge/main.py | 13 +++++++++++++ |
16 |
> 3 files changed, 17 insertions(+), 1 deletion(-) |
17 |
> |
18 |
> diff --git a/man/emerge.1 b/man/emerge.1 |
19 |
> index a2cb3f6..2264b58 100644 |
20 |
> --- a/man/emerge.1 |
21 |
> +++ b/man/emerge.1 |
22 |
> @@ -716,6 +716,9 @@ Disable the warning message that's shown prior to |
23 |
> to be set in the \fBmake.conf\fR(5) |
24 |
> \fBEMERGE_DEFAULT_OPTS\fR variable. |
25 |
> .TP |
26 |
> +.BR "\-\-read-news [ y | n ]" |
27 |
> +Offer to read news via eselect if there are unread news. |
28 |
> +.TP |
29 |
> .BR "\-\-rebuild\-if\-new\-slot [ y | n ]" |
30 |
> Automatically rebuild or reinstall packages when slot/sub\-slot := |
31 |
> operator dependencies can be satisfied by a newer slot, so that |
32 |
> diff --git a/pym/_emerge/actions.py b/pym/_emerge/actions.py |
33 |
> index 9036810..4e8b83b 100644 |
34 |
> --- a/pym/_emerge/actions.py |
35 |
> +++ b/pym/_emerge/actions.py |
36 |
> @@ -4064,7 +4064,7 @@ def run_action(emerge_config): |
37 |
> uq = UserQuery(emerge_config.opts) |
38 |
> if |
39 |
> display_news_notification(emerge_config.target_config, |
40 |
> emerge_config.opts) \ |
41 |
> - and "--ask" in emerge_config.opts \ |
42 |
> + and "--read-news" in |
43 |
> emerge_config.opts \ and uq.query("Would you like to read the news |
44 |
> items while " \ "calculating dependencies?", |
45 |
> '--ask-enter-invalid' |
46 |
> in emerge_config.opts) == "Yes": diff --git a/pym/_emerge/main.py |
47 |
> b/pym/_emerge/main.py index 52aa9c5..3883f72 100644 |
48 |
> --- a/pym/_emerge/main.py |
49 |
> +++ b/pym/_emerge/main.py |
50 |
> @@ -146,6 +146,7 @@ def insert_optional_args(args): |
51 |
> '--quiet' : y_or_n, |
52 |
> '--quiet-build' : y_or_n, |
53 |
> '--quiet-fail' : y_or_n, |
54 |
> + '--read-news' : y_or_n, |
55 |
> '--rebuild-if-new-slot': y_or_n, |
56 |
> '--rebuild-if-new-rev' : y_or_n, |
57 |
> '--rebuild-if-new-ver' : y_or_n, |
58 |
> @@ -557,6 +558,12 @@ def parse_opts(tmpcmdline, silent=False): |
59 |
> "choices" : true_y_or_n, |
60 |
> }, |
61 |
> |
62 |
> + "--read-news": { |
63 |
> + "help" : "offer to read unread news via |
64 |
> eselect", |
65 |
> + "choices" : true_y_or_n |
66 |
> + }, |
67 |
> + |
68 |
> + |
69 |
> "--rebuild-if-new-slot": { |
70 |
> "help" : ("Automatically rebuild or |
71 |
> reinstall packages when slot/sub-slot := " "operator dependencies can |
72 |
> be satisfied by a newer slot, so that " @@ -803,6 +810,12 @@ def |
73 |
> parse_opts(tmpcmdline, silent=False): if myoptions.quiet_fail in |
74 |
> true_y: myoptions.quiet_fail = 'y' |
75 |
> |
76 |
> + if myoptions.read_news in true_y: |
77 |
> + myoptions.read_news = True |
78 |
> + else: |
79 |
> + myoptions.read_news = None |
80 |
> + |
81 |
> + |
82 |
> if myoptions.rebuild_if_new_slot in true_y: |
83 |
> myoptions.rebuild_if_new_slot = 'y' |
84 |
> |
85 |
|
86 |
LGTM, merge please :) |
87 |
|
88 |
-- |
89 |
Brian Dolbec <dolsen> |