| 1 |
On 02/17/2015 10:58 AM, Brian Dolbec wrote: |
| 2 |
> |
| 3 |
> class Atom() |
| 4 |
> |
| 5 |
> if allow_repo is None: |
| 6 |
> allow_repo = True |
| 7 |
> + if allow_build_id is None: |
| 8 |
> + allow_build_id = True |
| 9 |
> |
| 10 |
> |
| 11 |
> these can be written as |
| 12 |
> allow_repo = allow_repo or True |
| 13 |
> allow_build_id = allow_build_id or True |
| 14 |
|
| 15 |
Actually, your version behaves differently than mine for the case where |
| 16 |
False has been passed in for these parameters. The parameters are |
| 17 |
designed are provide a "smart" default, as long as the caller has not |
| 18 |
passed in an explicit True or False value. |
| 19 |
-- |
| 20 |
Thanks, |
| 21 |
Zac |
Archives