Gentoo Archives: gentoo-portage-dev

From: Mike Gilbert <floppym@g.o>
To: gentoo-portage-dev@l.g.o
Subject: [gentoo-portage-dev] [PATCH] emerge: fix error handling for clean_logs
Date: Thu, 26 Jan 2017 03:16:40
Message-Id: 20170126031635.4585-1-floppym@gentoo.org
1 Commit f143e58dd changed the return value of CleanLogs.clean() to a
2 tuple (returncode, messages).
3
4 X-Gentoo-Bug: 607236
5 X-Gentoo-Bug-URL: https://bugs.gentoo.org/607236
6 ---
7 pym/_emerge/post_emerge.py | 6 +++---
8 1 file changed, 3 insertions(+), 3 deletions(-)
9
10 diff --git a/pym/_emerge/post_emerge.py b/pym/_emerge/post_emerge.py
11 index 0cb533cf8..7e6063c52 100644
12 --- a/pym/_emerge/post_emerge.py
13 +++ b/pym/_emerge/post_emerge.py
14 @@ -29,10 +29,10 @@ def clean_logs(settings):
15 return
16
17 cleanlogs = CleanLogs()
18 - errors = cleanlogs.clean(settings=settings)
19 - if errors:
20 + returncode, msgs = cleanlogs.clean(settings=settings)
21 + if not returncode:
22 out = portage.output.EOutput()
23 - for msg in errors:
24 + for msg in msgs:
25 out.eerror(msg)
26
27 def display_news_notification(root_config, myopts):
28 --
29 2.11.0

Replies