Gentoo Archives: gentoo-portage-dev

From: Zac Medico <zmedico@×××××.com>
To:
Cc: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [patch] dont run ldconfig unless libraries are actually installed
Date: Tue, 17 Jan 2006 08:41:03
Message-Id: 43CCADB7.5060305@gmail.com
In Reply to: Re: [gentoo-portage-dev] [patch] dont run ldconfig unless libraries are actually installed by Zac Medico
1 -----BEGIN PGP SIGNED MESSAGE-----
2 Hash: SHA1
3
4 Zac Medico wrote:
5 > Mike Frysinger wrote:
6 >>> makelinks is set to 1 by default when upgrading a package so that running
7 >>> ldconfig will update any shared lib links ... however, if the package doesnt
8 >>> install any libraries, then there's no point in running ldconfig
9 >
10 > I tried the updated patch and it works for me now. While reviewing the patch I got the impression that the os.access(srcroot+x,os.R_OK) thing and the mtimedb stuff are mutually redundant. Both are being used to track whether the installed package has changed libraries in the search path. In order to simplify the code, it seems logical to use either one or the other, not both.
11
12 I've revised the patch so that it relies on the mtimedb in order to determine whether or not ldconfig needs to be run (making the 'srcroot' parameter unnecessary). The revised patch assumes that it is not necessary to run ldconfig when the mtimedb contains matching mtimes for all existent paths in the search path (nonexistent paths are ignored).
13
14 Zac
15 -----BEGIN PGP SIGNATURE-----
16 Version: GnuPG v1.4.2 (GNU/Linux)
17
18 iD8DBQFDzK23/ejvha5XGaMRAh+mAJ9PkFg6BQINfBXerZrY34f+0QpRiQCePR1M
19 ISuHnCjy8sofNlj9eQFWFmk=
20 =48g9
21 -----END PGP SIGNATURE-----

Attachments

File name MIME type
ldconfig-only-when-needed-mtimedb.patch text/x-patch