Gentoo Archives: gentoo-portage-dev

From: Zac Medico <zmedico@g.o>
To: gentoo-portage-dev@l.g.o
Cc: "Michał Górny" <mgorny@g.o>
Subject: Re: [gentoo-portage-dev] [PATCH] cvs sync: fix the module
Date: Sun, 18 Jan 2015 01:10:23
Message-Id: 54BB07F8.7030300@gentoo.org
In Reply to: [gentoo-portage-dev] [PATCH] cvs sync: fix the module by "Michał Górny"
1 On 01/17/2015 09:36 AM, Michał Górny wrote:
2 > Fix the cvs sync module since it doesn't work at all right now. More
3 > specifically:
4 >
5 > 1. add exists() method that checks for the 'CVS' sub-directory to determine
6 > whether the repository was checked out already.
7 >
8 > 2. Do not remove the just-created directory on initial clone, to avoid
9 > permission issues. Just run checkout on top of it.
10 >
11 > 3. Fix the sync method to run update unconditionally to whether the URI
12 > starts with cvs:// or not. In fact, remove the whole check since it
13 > doesn't serve any purpose.
14 > ---
15 > pym/portage/sync/modules/cvs/cvs.py | 36 ++++++++++++++----------------------
16 > 1 file changed, 14 insertions(+), 22 deletions(-)
17
18 LGTM.
19 --
20 Thanks,
21 Zac