| 1 |
On 03/14/2016 06:04 PM, Zac Medico wrote: |
| 2 |
>> The only consumer for that allvalid variable is the metadata |
| 3 |
>> UnusedCheck class. |
| 4 |
>> |
| 5 |
>> So the allvalid variable is True until found False |
| 6 |
>> by whichever checks along the way find it to be False. Like a fuse, |
| 7 |
>> it's good until it's blown, then it can never be good again. I don't |
| 8 |
>> think this particular variable justifies a special class that more |
| 9 |
>> fully mimics a fuse. Impossible to reset it like a breaker. |
| 10 |
> |
| 11 |
> Yeah, let's do it. It's a great opportunity to add clarity to the code, |
| 12 |
> and prevent future goofs. |
| 13 |
|
| 14 |
We could have modules declare all of their input/output keys, filter |
| 15 |
input keys to only include those requested by the module, and trigger an |
| 16 |
error if a module's invocation returns unexpected key(s). That way, the |
| 17 |
interfaces will be clearly defined (we can even assert specific types if |
| 18 |
we want), and it will be much easier for a person to reason about the |
| 19 |
system. |
| 20 |
-- |
| 21 |
Thanks, |
| 22 |
Zac |
Archives