1 |
On Mon, 4 Aug 2014 23:51:00 +0200 |
2 |
Michał Górny <mgorny@g.o> wrote: |
3 |
|
4 |
> Dnia 2014-08-04, o godz. 11:02:27 |
5 |
> Michał Górny <mgorny@g.o> napisał(a): |
6 |
> |
7 |
> > The original checks assume that no-blocker is denoted as 'None'. |
8 |
> > However, currently atom.blocker returns just 'False'. |
9 |
> |
10 |
> So, applying this patch restores the 'dependency.unknown' check that |
11 |
> wasn't working for some time. As a result, I think it slows down |
12 |
> repoman near GNOME & KDE categories (though no real measurements), |
13 |
> and gives 4779 new warnings. |
14 |
> |
15 |
> Some of those warnings concern only || () dependencies, e.g.: |
16 |
> |
17 |
> x11-wm/awesome/awesome-3.5.5.ebuild: DEPEND: |
18 |
> <x11-libs/libX11-1.3.99.901[xcb] |
19 |
> |
20 |
> which applies to: |
21 |
> |
22 |
> || ( <x11-libs/libX11-1.3.99.901[xcb] >=x11-libs/libX11-1.3.99.901 ) |
23 |
> |
24 |
> in the ebuild. |
25 |
> |
26 |
> However, some look like false positives and need further |
27 |
> investigation: |
28 |
> |
29 |
> app-emulation/emul-linux-x86-baselibs/emul-linux-x86-baselibs-20140406-r4.ebuild: |
30 |
> RDEPEND: >=app-arch/bzip2-1.0.6-r4[abi_x86_32(-)], |
31 |
> >=app-arch/xz-utils-5.0.5-r1[abi_x86_32(-)], |
32 |
> >>=app-text/libpaper-1.1.24-r2[abi_x86_32(-)], |
33 |
> >>>=dev-db/sqlite-3.8.3:3[abi_x86_32(-)], |
34 |
> >>>>=dev-libs/dbus-glib-0.100.2-r1[abi_x86_32(-)], |
35 |
> >>>>>=dev-libs/elfutils-0.155-r1[abi_x86_32(-)], |
36 |
> >>>>>>=dev-libs/expat-2.1.0-r3[abi_x86_32(-)], |
37 |
> >>>>>>>=dev-libs/glib-2.34.3:2[abi_x86_32(-)], |
38 |
> >>>>>>>>=dev-libs/gmp-5.1.3-r1[abi_x86_32(-)], |
39 |
> >>>>>>>>>=dev-libs/json-c-0.11-r1[abi_x86_32(-)], |
40 |
> >>>>>>>>>>=dev-libs/libelf-0.8.13-r2[abi_x86_32(-)], |
41 |
> >>>>>>>>>>>=dev-libs/libgcrypt-1.5.3-r100:11[abi_x86_32(-)], |
42 |
> >>>>>>>>>>>>=dev-libs/libgcrypt-1.6.1-r1:0[abi_x86_32(-)], |
43 |
> >>>>>>>>>>>>>=dev-libs/libgpg-error-1.12-r1[abi_x86_32(-)], |
44 |
> >>>>>>>>>>>>>>=dev-libs/libpcre-8.33-r1[abi_x86_32(-)], |
45 |
> >>>>>>>>>>>>>>>=dev-libs/libtasn1-3.4-r1[abi_x86_32(-)], |
46 |
> >>>>>>>>>>>>>>>>=dev-libs/libxml2-2.9.1-r4[abi_x86_32(-)], |
47 |
> >>>>>>>>>>>>>>>>>=dev-libs/libxslt-1.1.28-r2[abi_x86_32(-)], |
48 |
> >>>>>>>>>>>>>>>>>>=dev-libs/lzo-2.06-r1[abi_x86_32(-)], |
49 |
> >>>>>>>>>>>>>>>>>>>=dev-libs/nettle-2.7.1-r1[abi_x86_32(-)], |
50 |
> >>>>>>>>>>>>>>>>>>>>=dev-libs/openssl-1.0.1h-r2[abi_x86_32(-)], |
51 |
> >>>>>>>>>>>>>>>>>>>>>=dev-libs/udis86-1.7-r2[abi_x86_32(-)], |
52 |
> >>>>>>>>>>>>>>>>>>>>>>=media-libs/giflib-4.2.3-r1[abi_x86_32(-)], |
53 |
> >>>>>>>>>>>>>>>>>>>>>>>=media-libs/lcms-2.5-r1:2[abi_x86_32(-)], |
54 |
> >>>>>>>>>>>>>>>>>>>>>>>>=media-libs/libpng-1.2.51:1.2[abi_x86_32(-)], |
55 |
> >>>>>>>>>>>>>>>>>>>>>>>>>=media-libs/libpng-1.6.10:0[abi_x86_32(-)], |
56 |
> >>>>>>>>>>>>>>>>>>>>>>>>>>=media-libs/tiff-3.9.7-r1:3[abi_x86_32(-)], |
57 |
> >>>>>>>>>>>>>>>>>>>>>>>>>>>=media-libs/tiff-4.0.3-r6:0[abi_x86_32(-)], |
58 |
> >>>>>>>>>>>>>>>>>>>>>>>>>>>>=sys-apps/acl-2.2.52-r1[abi_x86_32(-)], |
59 |
> >>>>>>>>>>>>>>>>>>>>>>>>>>>>>=sys-apps/attr-2.4.47-r1[abi_x86_32(-)], |
60 |
> >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>=sys-apps/dbus-1.6.18-r1[abi_x86_32(-)], |
61 |
> >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>=sys-apps/file-5.18-r1[abi_x86_32(-)], |
62 |
> >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>=sys-apps/tcp-wrappers-7.6.22-r1[abi_x86_32(-)], |
63 |
> >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>=sys-apps/util-linux-2.24.1-r3[abi_x86_32(-)], |
64 |
> >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>=sys-devel/gettext-0.18.3.2[abi_x86_32(-)], |
65 |
> >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>=sys-devel/libtool-2.4.2-r1[abi_x86_32(-)], |
66 |
> >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>=sys-devel/llvm-3.3-r3[abi_x86_32(-)], |
67 |
> >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>=sys-libs/e2fsprogs-libs-1.42.9[abi_x86_32(-)], |
68 |
> >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>=sys-libs/gdbm-1.10-r1[abi_x86_32(-)], |
69 |
> >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>=sys-libs/gpm-1.20.7-r2[abi_x86_32(-)], |
70 |
> >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>=sys-libs/libavc1394-0.5.4-r1[abi_x86_32(-)], |
71 |
> >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>=sys-libs/libraw1394-2.1.0-r1[abi_x86_32(-)], |
72 |
> >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>=sys-libs/ncurses-5.9-r3[abi_x86_32(-)], |
73 |
> >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>=sys-libs/readline-6.2_p5-r1:0[abi_x86_32(-)], |
74 |
> >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>=sys-libs/slang-2.2.4-r1[abi_x86_32(-)], |
75 |
> >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>=sys-libs/zlib-1.2.8-r1[abi_x86_32(-)] |
76 |
> |
77 |
> CC-ing multilib@ for consultation :). |
78 |
> |
79 |
> I don't think this should prevent us from committing the patch, |
80 |
> however. If we believe the potential false positives are important |
81 |
> enough, we should just add explanatory 'if False' instead of keeping |
82 |
> a code bug ;). |
83 |
> |
84 |
|
85 |
Since, TomWij isn't around atm. |
86 |
|
87 |
ack to commit this patch. |
88 |
|
89 |
-- |
90 |
Brian Dolbec <dolsen> |