Gentoo Archives: gentoo-portage-dev

From: Zac Medico <zmedico@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH v2] repoman: add a mini framework for checking eclasses, and fill it out
Date: Thu, 24 May 2012 21:16:34
Message-Id: 4FBE944E.7080103@gentoo.org
In Reply to: [gentoo-portage-dev] [PATCH v2] repoman: add a mini framework for checking eclasses, and fill it out by Mike Frysinger
1 On 05/24/2012 12:20 PM, Mike Frysinger wrote:
2 > Rather than copying & pasting the same behavior for the different eclass
3 > checks, add a common class for them to extend. This makes adding more
4 > eclass checks trivial, and keeps down bitrot.
5 >
6 > This does abuse the checking interface slightly -- the eclass will change
7 > its category between unused and missing based on the checks.
8 >
9 > URL: https://bugs.gentoo.org/417159
10 > URL: https://bugs.gentoo.org/417231
11 > Signed-off-by: Mike Frysinger <vapier@g.o>
12 > ---
13 > v2
14 > - fix optimization aspects
15
16 Looks good to me.
17 --
18 Thanks,
19 Zac

Replies