Gentoo Archives: gentoo-portage-dev

From: Mike Frysinger <vapier@g.o>
To: gentoo-portage-dev@l.g.o
Cc: Alec Warner <antarus@g.o>
Subject: Re: [gentoo-portage-dev] [PATCH 0/3] Initial fetch() refactoring
Date: Wed, 22 Jan 2014 05:34:00
Message-Id: 201401220034.03209.vapier@gentoo.org
In Reply to: Re: [gentoo-portage-dev] [PATCH 0/3] Initial fetch() refactoring by Alec Warner
1 On Sunday 19 January 2014 17:46:36 Alec Warner wrote:
2 > On Sun, Jan 19, 2014 at 2:45 PM, Alexander Berntsen wrote:
3 > > On 19/01/14 22:22, Sebastian Luther wrote:
4 > > > The usual doc string style used in portage is:
5 > > >
6 > > > """ text """
7 > > >
8 > > > Please use that for new functions. Also make sure you don't use
9 > > > spaces to indent the last """.
10 > >
11 > > As mentioned by Mike in another thread, we should use PEP 257[0]. I
12 > > will convert old code to conform to this... sometime... soon... (I
13 > > promise!)
14 > >
15 > > So if new patches could just do that right away, that would be neat.
16 >
17 > Does pylint or pyflakes point out if you mess it up?
18 >
19 > Automation for the win.
20
21 the good news is that i wrote a pylintrc module for Chromium OS to enforce
22 docstring style. the bad news is that it doesn't work with pyflakes.
23 https://chromium.googlesource.com/chromiumos/chromite/+/master/cros/commands/lint.py
24
25 what we did there was just merge it and then have people fix things up as they
26 went rather than try to clean it all up first.
27 -mike

Attachments

File name MIME type
signature.asc application/pgp-signature