| 1 |
>>>>> On Sun, 26 Sep 2021, Michał Górny wrote: |
| 2 |
|
| 3 |
> Symlinking FILESDIR into the work tree has the unintended consequence |
| 4 |
> of preserving all original file metadata, including system-specific ACLs |
| 5 |
> and so on. When these files are installed, this could lead to |
| 6 |
> unintentionally copying this metadata to the system and/or binary |
| 7 |
> packages. |
| 8 |
|
| 9 |
> Let's copy all files instead and drop metadata in the process. Since |
| 10 |
> FILESDIR is expected to be small by design, this shouldn't cause any |
| 11 |
> major trouble. It is also easier and less likely to cause regressions |
| 12 |
> than making sure stuff is not preserved when installing. |
| 13 |
|
| 14 |
> Unfortunately, a similar problem applies to DISTDIR. However, |
| 15 |
> installing files from DISTDIR is rarer than from FILESDIR, so I guess |
| 16 |
> we'll cross that bridge when we get to it. |
| 17 |
|
| 18 |
Sorry for the late reply, but this looks like the wrong solution to me. |
| 19 |
|
| 20 |
Looking at the installation helpers (doins, doexe, etc.), they don't |
| 21 |
preserve the normal permission bits, but reset them to a defined state. |
| 22 |
So why would they preserve xattrs? |
| 23 |
|
| 24 |
I don't see anything in PMS that would mandate that behaviour (on the |
| 25 |
contrary, in section 13.3.1 there is "Other file attributes may be |
| 26 |
discarded"). How do the other package managers handle this? |
| 27 |
|
| 28 |
Ulrich |
Archives