Gentoo Archives: gentoo-portage-dev

From: Ulrich Mueller <ulm@g.o>
To: "Michał Górny" <mgorny@g.o>
Cc: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH v3] Copy files/* into the work tree instead of symlinking it
Date: Mon, 27 Sep 2021 10:49:19
In Reply to: [gentoo-portage-dev] [PATCH v3] Copy files/* into the work tree instead of symlinking it by "Michał Górny"
1 >>>>> On Sun, 26 Sep 2021, Michał Górny wrote:
3 > Symlinking FILESDIR into the work tree has the unintended consequence
4 > of preserving all original file metadata, including system-specific ACLs
5 > and so on. When these files are installed, this could lead to
6 > unintentionally copying this metadata to the system and/or binary
7 > packages.
9 > Let's copy all files instead and drop metadata in the process. Since
10 > FILESDIR is expected to be small by design, this shouldn't cause any
11 > major trouble. It is also easier and less likely to cause regressions
12 > than making sure stuff is not preserved when installing.
14 > Unfortunately, a similar problem applies to DISTDIR. However,
15 > installing files from DISTDIR is rarer than from FILESDIR, so I guess
16 > we'll cross that bridge when we get to it.
18 Sorry for the late reply, but this looks like the wrong solution to me.
20 Looking at the installation helpers (doins, doexe, etc.), they don't
21 preserve the normal permission bits, but reset them to a defined state.
22 So why would they preserve xattrs?
24 I don't see anything in PMS that would mandate that behaviour (on the
25 contrary, in section 13.3.1 there is "Other file attributes may be
26 discarded"). How do the other package managers handle this?
28 Ulrich


File name MIME type
signature.asc application/pgp-signature