Gentoo Archives: gentoo-portage-dev

From: Matthew Thode <prometheanfire@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] Commit Policy
Date: Fri, 10 Jan 2014 17:24:00
Message-Id: 52D02CB8.9010607@gentoo.org
In Reply to: [gentoo-portage-dev] Commit Policy by Brian Dolbec
1 On 01/10/2014 04:35 AM, Brian Dolbec wrote:
2 > First off. Welcome and than you for responding to help with portage.
3 >
4 > With this many people, we should be able to make good progress without
5 > overloading any one person.
6 >
7 > General rule is to submit all patches to this list for review and
8 > approval before committing.
9 >
10 > Remember to do these always:
11 > 1) run pyflakes on your changes to check for faults, misssing imports,
12 > variables undefined,...
13 >
14 > 2) run the testsuite to check for breakage. It is in the base directory
15 > called runtests.sh. Please try to test it with all minimum supported
16 > python versions, but if you have pypy, and some others, then great.
17 >
18 > 3) any new code that could break things, make a test for it if at all
19 > possible.
20 >
21 >
22 > The general exception for patch submittal is for trivial changes such as
23 > typo fixes, etc..
24 >
25 > It will take a bit of time for everyone to acclimate themselves into our
26 > new team. So, I was thinking we give it 2 months, then hold an election
27 > for lead in March. Is that alright with everyone?
28 >
29 > Thanks
30 >
31 sounds good to me
32
33 --
34 -- Matthew Thode (prometheanfire)

Attachments

File name MIME type
signature.asc application/pgp-signature