| 1 |
On Sun, Jan 19, 2014 at 03:06:29PM -0800, W. Trevor King wrote: |
| 2 |
> On Sun, Jan 19, 2014 at 02:36:43PM -0800, Alec Warner wrote: |
| 3 |
> > On Sat, Jan 18, 2014 at 7:07 PM, W. Trevor King <wking@×××××××.us> wrote: |
| 4 |
> > > + # Order primaryuri_dict values to match that in SRC_URI. |
| 5 |
> > > + for uris in primaryuri_dict.values(): |
| 6 |
> > > + uris.reverse() |
| 7 |
> > |
| 8 |
> > Is there any guaranteed ordering for dict.values()? |
| 9 |
> |
| 10 |
> No. |
| 11 |
> |
| 12 |
> > I thought dict order was random (and they seriously make it random |
| 13 |
> > in modern python versions, to detect bugs.) How does this |
| 14 |
> > uris.reverse() match the SRC_URI ordering? |
| 15 |
> |
| 16 |
> No idea (copy-pasted code). I'd be happy to cut this out in v3. |
| 17 |
|
| 18 |
Ah, we're not reversing the ordering of values(), we're reversing the |
| 19 |
ordering of each individual value. Keeping it in. |
| 20 |
|
| 21 |
Cheers, |
| 22 |
Trevor |
| 23 |
|
| 24 |
-- |
| 25 |
This email may be signed or encrypted with GnuPG (http://www.gnupg.org). |
| 26 |
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy |
Archives