Re: [gentoo-portage-dev] [PATCH v3] portage.package.ebuild: Use a fake FILESDIR to catch invalid accesses

[Zac Medico]

On 03/21/2017 12:46 AM, Michał Górny wrote:
> Use a model of fake FILESDIR path to ensure that invalid accesses to
> FILESDIR will result in failures rather than being silently allowed by
> Portage. This mostly involves accesses in the global scope and pkg_*
> phases, although the current model does not cover the latter completely
> (i.e. does not guarantee that the directory is removed post src_*).
>
> This model aims to follow PMS wording quite precisely. The value of
> FILESDIR is meant to be stable throughout the build process, and it is
> reliably set to a temporary directory path. However, since the path is
> not guaranteed to be present outside src_*, the directory symlink is not
> actually created before src_* phases.
> ---
>  man/ebuild.5                                     |  6 +++---
>  pym/_emerge/EbuildPhase.py                       |  6 +++++-
>  pym/portage/package/ebuild/config.py             |  3 ---
>  pym/portage/package/ebuild/doebuild.py           |  2 +-
>  pym/portage/package/ebuild/prepare_build_dirs.py | 13 +++++++++++++
>  5 files changed, 22 insertions(+), 8 deletions(-)

Looks good now. Thanks!
-- 
Thanks,
Zac