Re: [gentoo-portage-dev] [PATCH] xattr: centralize the various shims in one place

[Mike Frysinger]

On Wednesday 16 October 2013 23:42:26 Arfrever Frehtes Taifersar wrote:
> 2013-10-17 04:53 Mike Frysinger napisał(a):
> > On Wednesday 16 October 2013 22:51:17 Mike Frysinger wrote:
> > > On Wednesday 16 October 2013 20:02:50 Arfrever Frehtes wrote:
> > > > 2013-10-16 23:03 Mike Frysinger napisał(a):
> > > > > Rather than each module implementing its own shim around the
> > > > > various methods for accessing extended attributes, start a
> > > > > dedicated module that exports a consistent API.
> > > >
> > > > Some things are incompatible with Python 3.
> > > > See other comments below.
> > >
> > > i can run a linter on the code (probably should make this a git hook).
> > > i'm interested more in review on the bigger picture.
> >
> > also, none of your comments were py3 issues that i saw
>
> I said "other comments", so I meant comments not related to incompatibility
> with Python 3.

well, w/out providing specific concerns, it's hard to address feedback

> About incompatibility with Python 3:
> - subprocess.check_output(), subprocess.Popen().stdout.read(),
> subprocess.Popen().stderr.read() return bytes, which is incorrectly
> compared with str in your patches.

i've changed the mock code to use subprocess directly so the tests catch this

> - dict.iteritems() was renamed to dict.items() (and its return type was
> changed from dictionary-itemiterator to dict_items, but it does not matter
> here).

fixed

> - Queue module was renamed to queue.

i've sent a patch upstream for this

> - cStringIO module should not be used. io module is a replacement available
> since Python 2.6.

unfortunately, that doesn't work as well as it should.  python 2.7's interface 
is annoyingly different when using other python 2.7 modules.  i'll have the 
code import the old module and then fallback to using the new io module.

> - Maybe other problems...

sorry, but this isn't useful.  i'm going to run the unittests against python 
3.2 and 3.3 and once those pass, i'm done looking at it.
-mike