Gentoo Archives: gentoo-portage-dev

From:	Brian Dolbec <dolsen@g.o>
To:	gentoo-portage-dev@l.g.o
Subject:	Re: [gentoo-portage-dev] [PATCH v2] NewsManager.getUnreadItems: handle EROFS (490732)
Date:	Mon, 17 Nov 2014 22:47:20
Message-Id:	`20141117144708.1008e0dc.dolsen@gentoo.org`
In Reply to:	[gentoo-portage-dev] [PATCH v2] NewsManager.getUnreadItems: handle EROFS (490732) by Zac Medico

1	On Fri, 14 Nov 2014 20:45:11 -0800
2	Zac Medico <zmedico@g.o> wrote:
3
4	> When getUnreadItems tries to lock the news.unread file, it's safe to
5	> ignore EROFS. This is handled with a ReadOnlyFileSystem exception
6	> raised from the portage.locks.lockfile function.
7	>
8	> X-Gentoo-Bug: 490732
9	> X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=490732
10	> ---
11	> This updated patch fixes the typo spotted by Brian Dolbec.
12	>
13
14	LGTM, go for it.
15
16
17	but for future reference...
18
19
20	use brackets to group multiline imports instead of line continuations.
21
22	- from portage.exception import InvalidLocation, OperationNotPermitted, \
23	- PermissionDenied
24	+ from portage.exception import (InvalidLocation, OperationNotPermitted,
25	+ PermissionDenied, ReadOnlyFileSystem)
26
27	--
28	Brian Dolbec <dolsen>