| 1 |
-----BEGIN PGP SIGNED MESSAGE----- |
| 2 |
Hash: SHA1 |
| 3 |
|
| 4 |
Zac Medico wrote: |
| 5 |
> http://bugs.gentoo.org/show_bug.cgi?id=102073 |
| 6 |
> |
| 7 |
> Author: Zac Medico |
| 8 |
> |
| 9 |
> Some refactoring could help make the emerge code more maintainable. I |
| 10 |
> have written a trivial patch that encapsulates the spinner code into an |
| 11 |
> object. This patch only reorganizes code and should not cause any |
| 12 |
> regressions or changes in functionality. |
| 13 |
> |
| 14 |
> Comments? |
| 15 |
> |
| 16 |
> Zac |
| 17 |
> |
| 18 |
<snip patch> |
| 19 |
|
| 20 |
I would vote no, but I would hang onto the class. "If it ain't broke, |
| 21 |
don't fix it" IMHO. Emerge is a beast held together by fine twine, and |
| 22 |
messing with a stable thing trying to clean it up is at best a fun |
| 23 |
untested mess. It should be rewritten for the next version and that |
| 24 |
class may come in handly to make the spinner code ( if there indeed is |
| 25 |
any ) a bit cleaner. |
| 26 |
-----BEGIN PGP SIGNATURE----- |
| 27 |
Version: GnuPG v1.4.1 (GNU/Linux) |
| 28 |
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org |
| 29 |
|
| 30 |
iQIVAwUBQvtBJGzglR5RwbyYAQKcFw/9GyDPIqCf/gpHmTU1qVcTgsOQ3O5UR7gp |
| 31 |
WUkqpT3V+EP6VArovpgi/edvZtYcnFyX6V2kDZBXdiBEm2189QkPEWNfQxqyNRwp |
| 32 |
dq7QfVg9mFDF5mkTdKlSNhl7yO8fibkcY36cSwINNaPaRHZeC04fv56R8kQRr+Zl |
| 33 |
DXwjN4hMdnKWNM2NQGxIvx/TdfWR0wUSOfvVt6Q9IrVoQ2k2GUzzYuFg3aSF5m8k |
| 34 |
lThnn5uYYd8kd/cRUiqsycdZdRC+OykTZBN5sxHND8uzZk7lA+ietUWV9EFg6arr |
| 35 |
Y87cGCkNASg84+vVulR9CilNeYhFsfE7djmfH0ASmgl/9K7YnihVXcwdH9KRHCy5 |
| 36 |
0cQLacW11/AtxotrhxcGw/w1HawiW26vgpgXMi31o+wIIrCs7L/bJsSE+4X44bX7 |
| 37 |
4UIaxZRekgOBAIWr1nimdAy5SPMZ51dhpOf/c7kT1NHTK6aoE6m4JJL5wxDvlido |
| 38 |
Zv1gbDrkKjiM57LOrng4PGT0rWjLt5dhOLSyDhJ6tb6tYD21b74w2PwsDCY7JAew |
| 39 |
hF5AnxrQEo738cvNrFESSzmqWoINqdT6RYHLNPpKWFTBVO8YbZ7E+G1aySxJSQx+ |
| 40 |
hDkGeRuWphlRS0ctKpvmCXiEgNdQY5z9O0DpkZ3YKH9KIldIXzI/ddjiheNTKsU9 |
| 41 |
BpyPl0mRqjY= |
| 42 |
=+/O5 |
| 43 |
-----END PGP SIGNATURE----- |
| 44 |
-- |
| 45 |
gentoo-portage-dev@g.o mailing list |
Archives