Gentoo Archives: gentoo-portage-dev

From: Ulrich Mueller <ulm@g.o>
To: Fabian Groffen <grobian@g.o>
Cc: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH] doins: fix D check, add EPREFIX check
Date: Mon, 25 Jul 2022 17:50:53
Message-Id: u5yjlxery@gentoo.org
In Reply to: [gentoo-portage-dev] [PATCH] doins: fix D check, add EPREFIX check by Fabian Groffen
1 >>>>> On Mon, 25 Jul 2022, Fabian Groffen wrote:
2
3 > @@ -50,6 +51,16 @@ if [[ ${_E_INSDESTTREE_#${ED}} != "${_E_INSDESTTREE_}" ]]; then
4 > __helpers_die "${helper} used with \${D} or \${ED}"
5 > exit 1
6 > fi
7 > +if [[ -n ${EPREFIX} && \
8 > + ${_E_INSDESTTREE_#${EPREFIX}} != "${_E_INSDESTTREE_}" ]];
9
10 The semicolon is redundant.
11
12 > +then
13 > + __vecho "-------------------------------------------------------" 1>&2
14 > + __vecho "You should not use \${EPREFIX} with helpers." 1>&2
15 > + __vecho " --> ${_E_INSDESTTREE_}" 1>&2
16 > + __vecho "-------------------------------------------------------" 1>&2
17 > + __helpers_die "${helper} used with \${EPREFIX}"
18 > + exit 1
19 > +fi

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies