Gentoo Archives: gentoo-portage-dev

From: Mike Frysinger <vapier@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH v2] repoman: add a mini framework for checking eclasses, and fill it out
Date: Thu, 31 May 2012 03:09:26
Message-Id: 201205302157.22539.vapier@gentoo.org
In Reply to: Re: [gentoo-portage-dev] [PATCH v2] repoman: add a mini framework for checking eclasses, and fill it out by Zac Medico
1 On Wednesday 30 May 2012 21:00:33 Zac Medico wrote:
2 > On 05/30/2012 05:42 PM, Mike Frysinger wrote:
3 > > On Wednesday 30 May 2012 20:18:11 Zac Medico wrote:
4 > >> Do you want to support EGIT_BOOTSTRAP settings prior to inherit?
5 > >>
6 > >> For example, dev-libs/polylib/polylib-9999.ebuild triggers
7 > >> inherit.missing because InheritEclass currently expects the inherit to
8 > >> occur before the EGIT_BOOTSTRAP="eautoreconf" setting.
9 > >
10 > > i don't think we need to support that level of detection. it's a fairly
11 > > extreme edge case, and we can just let the git eclass say "allow implicit
12 > > autotools eclass inclusion" all the time.
13 >
14 > Okay, this seems to do the trick:
15 >
16 > http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=6d3873
17 > a690ccdf47f1d5c3f83fc8dbef92f5a9f1
18
19 LGTM
20 -mike

Attachments

File name MIME type
signature.asc application/pgp-signature